linux-kernel - Re: [PATCH] memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47f72a91-6af1-d82f-8e4a-b8929725ff19@arm.com>
Date:   Thu, 2 Jun 2022 08:40:07 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-pm@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Fix refcount leak in
 of_get_dram_timings



On 6/2/22 05:17, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> This function doesn't call of_node_put() in some error paths.
> To unify the structure, Add put_node label and goto it on errors.
> 
> Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Thanks for the patch, LGTM.

Reviewed-by: Lukasz Luba <lukasz.luba@....com>