linux-kernel - Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220602084037.c2pslwra4dyhnh3d@penduick>
Date:   Thu, 2 Jun 2022 10:40:37 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     laurent.pinchart@...asonboard.com, andrzej.hajda@...el.com,
        narmstrong@...libre.com, robert.foss@...aro.org, jonas@...boo.se,
        jernej.skrabec@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        sam@...nborg.org, alsi@...g-olufsen.dk, jagan@...rulasolutions.com,
        biju.das.jz@...renesas.com, l.stach@...gutronix.de,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: adv7511: Add check for
 mipi_dsi_driver_register

On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote:
> On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote:
> >> Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue.
> >> Therefore, it might not be necessary to add another mipi_dsi_driver_unregister().
> > 
> > The issue is that adv7511_exit() is not called if adv7511_init() fails.
> 
> Sorry, I can not find the caller of adv7511_init().
> Please give me more detail.

It's called by the kernel when the module is unloaded (module_exit).
It's not what Laurent is saying though.

His point is that in adv7511, if i2c_add_driver fails, you'll still need
to call mipi_dsi_driver_unregister to clean things up.

Maxime