linux-kernel - Re: [PATCH 1/3] dt-bindings: iommu: mediatek: add binding documentation for MT8365 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Jun 2022 16:42:24 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Yong Wu <yong.wu@...iatek.com>,
        Fabien Parent <fparent@...libre.com>
CC:     Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <iommu@...ts.linux-foundation.org>,
        <linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Bear Wang <bear.wang@...iatek.com>,
        Macross Chen <macross.chen@...iatek.com>,
        Kidd-KW Chen <Kidd-KW.Chen@...iatek.com>,
        Andy Hsieh <Andy.Hsieh@...iatek.com>,
        Pablo Sun <pablo.sun@...iatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: iommu: mediatek: add binding
 documentation for MT8365 SoC

On 6/2/22 4:27 PM, Macpaul Lin wrote:
> On 6/2/22 2:18 PM, Yong Wu wrote:
>> On Mon, 2022-05-30 at 20:03 +0200, Fabien Parent wrote:
>>> Add IOMMU binding documentation for the MT8365 SoC.
>>>
>>> Signed-off-by: Fabien Parent <fparent@...libre.com>
>>> ---
>>>   .../bindings/iommu/mediatek,iommu.yaml        |  2 +
>>>   include/dt-bindings/memory/mt8365-larb-port.h | 96
>>> +++++++++++++++++++
>>>   2 files changed, 98 insertions(+)
>>>   create mode 100644 include/dt-bindings/memory/mt8365-larb-port.h
>>
>> [snip...]
>>
>>> +#ifndef _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>>> +#define _DT_BINDINGS_MEMORY_MT8365_LARB_PORT_H_
>>> +
>>> +#include <dt-bindings/memory/mtk-memory-port.h>
>>> +
>>> +#define M4U_LARB0_ID            0
>>> +#define M4U_LARB1_ID            1
>>> +#define M4U_LARB2_ID            2
>>> +#define M4U_LARB3_ID            3
>>> +#define M4U_LARB4_ID            4
>>> +#define M4U_LARB5_ID            5
>>> +#define M4U_LARB6_ID            6
>>> +#define M4U_LARB7_ID            7
>>
>> Remove these. they are no used, right?
> 
> AIOT and customers are using the modules and their related IOMMU modules.
> DISP0, VENC, VDEC, ISP (CAMSYS), and APU (as far as I know, which should 
> be VP6?) were all supported.

Dear Yong,
How about to replace the following definitions?

For example, replace
#define M4U_PORT_DISP_OVL0		MTK_M4U_ID(0, 0)
to
#define M4U_PORT_DISP_OVL0              MTK_M4U_ID(M4U_LARB0_ID , 0)

>>
>>> +
>>> +/* larb0 */
>>> +#define M4U_PORT_DISP_OVL0        MTK_M4U_ID(0, 0)
>>> +#define M4U_PORT_DISP_OVL0_2L    MTK_M4U_ID(0, 1)
>>
>> [...]
>>
>>>
>>> +/* larb4 */
>>> +#define M4U_PORT_APU_READ        MTK_M4U_ID(0, 0)
>>> +#define M4U_PORT_APU_WRITE        MTK_M4U_ID(0, 1)
>>
>> Please remove these two APU definitions. currently these are not
>> supported.
> 
> Kidd, please help to check if APU use these definitions with Yong.
> However, I think these are all available to the customers.
> 
> Thanks
> Macpaul Lin

Thanks
Macpaul Lin