| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Jun 2022 18:05:32 +0800
From: kernel test robot <lkp@...el.com>
To: ChiaEn Wu <peterwu.pub@...il.com>, lee.jones@...aro.org,
daniel.thompson@...aro.org, jingoohan1@...il.com, pavel@....cz,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
matthias.bgg@...il.com, sre@...nel.org, chunfeng.yun@...iatek.com,
gregkh@...uxfoundation.org, jic23@...nel.org, lars@...afoo.de,
lgirdwood@...il.com, broonie@...nel.org, linux@...ck-us.net,
heikki.krogerus@...ux.intel.com, deller@....de
Cc: kbuild-all@...ts.01.org, cy_huang@...htek.com,
alice_chen@...htek.com, chiaen_wu@...htek.com,
peterwu.pub@...il.com, dri-devel@...ts.freedesktop.org,
linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-pm@...r.kernel.org, linux-usb@...r.kernel.org,
linux-iio@...r.kernel.org
Subject: Re: [RESEND 13/14] leds: flashlight: mt6370: Add Mediatek MT6370
flashlight support
Hi ChiaEn,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pavel-leds/for-next]
[also build test WARNING on lee-mfd/for-mfd-next lee-backlight/for-backlight-next v5.18 next-20220602]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/ChiaEn-Wu/Add-Mediatek-MT6370-PMIC-support/20220531-211432
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20220602/202206021739.LZjU7zjg-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/805a8af17c769562ec4b85e9b7d2669d004fe3a6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review ChiaEn-Wu/Add-Mediatek-MT6370-PMIC-support/20220531-211432
git checkout 805a8af17c769562ec4b85e9b7d2669d004fe3a6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/gpu/drm/v3d/ drivers/leds/ sound/core/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/leds.h:12,
from include/linux/led-class-flash.h:11,
from drivers/leds/flash/leds-mt6370-flash.c:8:
drivers/leds/flash/leds-mt6370-flash.c: In function 'mt6370_led_probe':
>> drivers/leds/flash/leds-mt6370-flash.c:591:17: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
591 | "No child node or node count over max led number %lu\n", count);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
drivers/leds/flash/leds-mt6370-flash.c:590:17: note: in expansion of macro 'dev_err'
590 | dev_err(&pdev->dev,
| ^~~~~~~
drivers/leds/flash/leds-mt6370-flash.c:591:68: note: format string is defined here
591 | "No child node or node count over max led number %lu\n", count);
| ~~^
| |
| long unsigned int
| %u
vim +591 drivers/leds/flash/leds-mt6370-flash.c
580
581 static int mt6370_led_probe(struct platform_device *pdev)
582 {
583 struct mt6370_priv *priv;
584 struct fwnode_handle *child;
585 size_t count;
586 int i = 0, ret;
587
588 count = device_get_child_node_count(&pdev->dev);
589 if (!count || count > MT6370_MAX_LEDS) {
590 dev_err(&pdev->dev,
> 591 "No child node or node count over max led number %lu\n", count);
592 return -EINVAL;
593 }
594
595 priv = devm_kzalloc(&pdev->dev, struct_size(priv, leds, count),
596 GFP_KERNEL);
597 if (!priv)
598 return -ENOMEM;
599
600 priv->leds_count = count;
601 priv->dev = &pdev->dev;
602 mutex_init(&priv->lock);
603
604 priv->regmap = dev_get_regmap(pdev->dev.parent, NULL);
605 if (!priv->regmap) {
606 dev_err(&pdev->dev, "Failed to get parent regmap\n");
607 return -ENODEV;
608 }
609
610 device_for_each_child_node(&pdev->dev, child) {
611 struct mt6370_led *led = priv->leds + i;
612 struct led_init_data init_data = { .fwnode = child, };
613
614 led->priv = priv;
615 ret = mt6370_init_common_properties(led, &init_data);
616 if (ret)
617 goto out_flash_release;
618
619 ret = mt6370_init_flash_properties(led, &init_data);
620
621 if (ret)
622 goto out_flash_release;
623
624 ret = mt6370_led_register(&pdev->dev, led, &init_data);
625 if (ret)
626 goto out_flash_release;
627
628 i++;
629 }
630
631 platform_set_drvdata(pdev, priv);
632 return 0;
633
634 out_flash_release:
635 mt6370_v4l2_flash_release(priv);
636 return ret;
637 }
638
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists