linux-kernel - [PATCH] LoongArch: Fix unsigned expression compared with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  2 Jun 2022 12:00:12 +0800
From:   Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
To:     ardb@...nel.org
Cc:     chenhuacai@...nel.org, kernel@...0n.name,
        linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH] LoongArch: Fix unsigned expression compared with zero

Fix the following coccicheck warnings:

./arch/loongarch/kernel/efi.c:157:5-11: WARNING: Unsigned expression
compared with zero: status < 0.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
---
 arch/loongarch/kernel/efi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/loongarch/kernel/efi.c b/arch/loongarch/kernel/efi.c
index d36a325a990c..2f25a7fe0868 100644
--- a/arch/loongarch/kernel/efi.c
+++ b/arch/loongarch/kernel/efi.c
@@ -145,16 +145,13 @@ static int __init set_virtual_map(void)
 
 void __init efi_runtime_init(void)
 {
-	efi_status_t status;
-
 	if (!efi_enabled(EFI_BOOT))
 		return;
 
 	if (!efi_systab->runtime)
 		return;
 
-	status = set_virtual_map();
-	if (status < 0)
+	if (set_virtual_map() < 0)
 		return;
 
 	if (efi_runtime_disabled()) {
-- 
2.20.1.7.g153144c