linux-kernel - Re: [PATCH v1 1/1] kernel.h: Move sysfs related macro to sysfs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220603121511.78aa66b02376d02557c29819@linux-foundation.org>
Date:   Fri, 3 Jun 2022 12:15:11 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Krzysztof Wilczyński <kw@...ux.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] kernel.h: Move sysfs related macro to sysfs.h

On Fri,  3 Jun 2022 20:21:01 +0300 Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> As stated in the comment of VERIFY_OCTAL_PERMISSIONS() it's related to sysfs.
> Move it to the corresponding header.

arm allmodconfig:

In file included from arch/arm/mm/alignment.c:11:
./include/linux/moduleparam.h:294:13: error: implicit declaration of function 'VERIFY_OCTAL_PERMISSIONS' [-Werror=implicit-function-declaration]
  294 |             VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
      |             ^~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/moduleparam.h:330:9: note: in expansion of macro '__module_param_call'
  330 |         __module_param_call("", name, &param_ops_##type, &var, perm, -1, 0)
      |         ^~~~~~~~~~~~~~~~~~~
arch/arm/mm/alignment.c:87:1: note: in expansion of macro 'core_param'
   87 | core_param(alignment, ai_usermode, int, 0600);
      | ^~~~~~~~~~
./include/linux/moduleparam.h:294:13: error: initializer element is not constant
  294 |             VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
      |             ^~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/moduleparam.h:330:9: note: in expansion of macro '__module_param_call'
  330 |         __module_param_call("", name, &param_ops_##type, &var, perm, -1, 0)
      |         ^~~~~~~~~~~~~~~~~~~
arch/arm/mm/alignment.c:87:1: note: in expansion of macro 'core_param'
   87 | core_param(alignment, ai_usermode, int, 0600);
      | ^~~~~~~~~~
./include/linux/moduleparam.h:294:13: note: (near initialization for '__param_alignment.perm')
  294 |             VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
      |             ^~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/moduleparam.h:330:9: note: in expansion of macro '__module_param_call'
  330 |         __module_param_call("", name, &param_ops_##type, &var, perm, -1, 0)
      |         ^~~~~~~~~~~~~~~~~~~
arch/arm/mm/alignment.c:87:1: note: in expansion of macro 'core_param'
   87 | core_param(alignment, ai_usermode, int, 0600);
      | ^~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [scripts/Makefile.build:271: arch/arm/mm/alignment.o] Error 1
make[1]: *** [scripts/Makefile.build:500: arch/arm/mm] Error 2
make: *** [Makefile:1839: arch/arm] Error 2