linux-kernel - RE: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jun 2022 07:01:08 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>
Cc:     <devicetree@...r.kernel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <vkoul@...nel.org>,
        <avri.altman@....com>, <bvanassche@....org>,
        <martin.petersen@...cle.com>, <chanho61.park@...sung.com>,
        <pankaj.dubey@...sung.com>, <linux-fsd@...la.com>,
        "'Bharat Uppal'" <bharat.uppal@...sung.com>
Subject: RE: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
>Sent: Tuesday, May 31, 2022 3:26 PM
>To: Alim Akhtar <alim.akhtar@...sung.com>; linux-arm-
>kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
>scsi@...r.kernel.org; linux-phy@...ts.infradead.org
>Cc: devicetree@...r.kernel.org; robh+dt@...nel.org;
>krzysztof.kozlowski+dt@...aro.org; vkoul@...nel.org; avri.altman@....com;
>bvanassche@....org; martin.petersen@...cle.com;
>chanho61.park@...sung.com; pankaj.dubey@...sung.com; linux-
>fsd@...la.com; Bharat Uppal <bharat.uppal@...sung.com>
>Subject: Re: [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata
>
>On 31/05/2022 03:22, Alim Akhtar wrote:
>> Move CDR lock offset to drv data so that it can be extended for other
>> SoCs which are having CDR lock at different register offset.
>>
>> Cc: linux-fsd@...la.com
>> Signed-off-by: Bharat Uppal <bharat.uppal@...sung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
>> ---
>>  drivers/phy/samsung/phy-exynos7-ufs.c      | 3 +++
>>  drivers/phy/samsung/phy-exynosautov9-ufs.c | 2 ++
>>  drivers/phy/samsung/phy-samsung-ufs.c      | 3 ++-
>>  drivers/phy/samsung/phy-samsung-ufs.h      | 2 +-
>>  4 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/phy/samsung/phy-exynos7-ufs.c
>> b/drivers/phy/samsung/phy-exynos7-ufs.c
>> index 7c9008e163db..d1a37273cb1f 100644
>> --- a/drivers/phy/samsung/phy-exynos7-ufs.c
>> +++ b/drivers/phy/samsung/phy-exynos7-ufs.c
>> @@ -11,6 +11,8 @@
>>  #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_MASK	0x1
>>  #define EXYNOS7_EMBEDDED_COMBO_PHY_CTRL_EN	BIT(0)
>>
>> +#define PHY_CDR_LOCK_STATUS    0x5e
>
>This should be now renamed to match other defines here, so
>EXYNOS7_EMBEDDED_COMBO_PHY_CDR_LOCK_STATUS
>
Sure, will update in next version
>
>Best regards,
>Krzysztof