linux-kernel - Re: [PATCH v3 5/5] dt-bindings: altera: Add Chameleon v3 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7374666a-212f-76fb-4626-386e46f74cd8@linaro.org>
Date:   Fri, 3 Jun 2022 09:28:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Paweł Anikiel <pan@...ihalf.com>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        dinguyen@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, amstan@...omium.org,
        upstream@...ihalf.com
Subject: Re: [PATCH v3 5/5] dt-bindings: altera: Add Chameleon v3 board

On 03/06/2022 08:58, Paweł Anikiel wrote:
> Add Mercury+ AA1 boards category, together with the Chameleon v3 board.
> 
> Signed-off-by: Paweł Anikiel <pan@...ihalf.com>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 5e2017c0a051..4a08c082dbdb 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -29,6 +29,14 @@ properties:
>            - const: altr,socfpga-arria10
>            - const: altr,socfpga
>  
> +      - description: Mercury+ AA1 boards

This looks good but you also need to remove enclustra,mercury-aa1 from
previous entry because after your changes to DTSI, it should not be a
standalone (final) compatible.

> +        items:
> +          - enum:
> +              - google,chameleon-v3
> +          - const: enclustra,mercury-aa1
> +          - const: altr,socfpga-arria10
> +          - const: altr,socfpga
> +
>        - description: Cyclone 5 boards
>          items:
>            - enum:


Best regards,
Krzysztof