linux-kernel - Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <213e966d-ac69-b5be-52ad-4ab9f616565e@pengutronix.de>
Date:   Fri, 3 Jun 2022 13:34:22 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Leonard Göhrs <l.goehrs@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on
 stm32mp15xx-osd32

On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
> 
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
> 
> Signed-off-by: Leonard Göhrs <l.goehrs@...gutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Thanks,
Ahmad

> ---
>  arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@...00000 {
>  			no-map;
>  		};
>  	};
> -
> -	reg_sip_eeprom: regulator_eeprom {
> -		compatible = "regulator-fixed";
> -		regulator-name = "sip_eeprom";
> -		regulator-always-on;
> -	};
>  };
>  
>  &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>  
>  	sip_eeprom: eeprom@50 {
>  		compatible = "atmel,24c32";
> -		vcc-supply = <&reg_sip_eeprom>;
> +		vcc-supply = <&vdd>;
>  		reg = <0x50>;
>  	};
>  };


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |