linux-kernel - Re: [PATCH] dt-bindings: mtd: mxc-nand: Drop undocumented properties from example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Jun 2022 15:40:24 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-mtd@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: mxc-nand: Drop undocumented
 properties from example

Hi Rob, Marc,

robh@...nel.org wrote on Tue, 31 May 2022 10:05:15 -0500:

> On Fri, May 27, 2022 at 11:38:39AM +0200, Marc Kleine-Budde wrote:
> > On 25.05.2022 15:59:46, Rob Herring wrote:  
> > > With unevaluatedProperties issues fixed, 'nand-bus-width' and
> > > 'nand-ecc-mode' are flagged as undocumented. Removing them from the example
> > > is the easiest solution to silence the warnings.
> > > 
> > > Signed-off-by: Rob Herring <robh@...nel.org>  
> > 
> > At least the 'nand-bus-width' property is described in
> > "nand-controller.yaml" and the "mxc-nand.yaml" refers to it.
> > 
> > | allOf:
> > |   - $ref: "nand-controller.yaml"
> > 
> > Is this ref broken?  
> 
> Nope, read my note below. 'nand-bus-width' is documented as a nand chip 
> (child node) property, not a nand controller property.
> 
> 
> > regards,
> > Marc
> >   
> > > ---
> > > These properties may be deprecated, but they are still widely used in
> > > bindings. They either need to be documented (and marked deprecated) or
> > > removed from current users (i.e. dts files).  

I don't mind keeping them undocumented to encourage people to migrate
to a better description. For the record, in the past controllers and
devices where not separated in the description, hence we had NAND chip
specific properties landing in to the NAND controller description.

So I'm fine with the current approach.

Thanks,
Miquèl