linux-kernel - Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkv9x3qu.fsf@meer.lwn.net>
Date:   Fri, 03 Jun 2022 07:42:33 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Bagas Sanjaya <bagasdotme@...il.com>, linux-doc@...r.kernel.org
Cc:     Bagas Sanjaya <bagasdotme@...il.com>, Pavel Machek <pavel@....cz>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of
 contents

Bagas Sanjaya <bagasdotme@...il.com> writes:

> After merging linux-leds tree to the mainline [1], htmldocs build produces
> a new warning:
>
> checking consistency... /home/bagas/repo/linux-stable/Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree
>
> The warning above is because leds-qcom-lpg.rst is missing in the table of
> contents.
>
> Add the missing entry.

The fix is good but ...

> [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/
>
> Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow documentation")

...I'm confused as to why you used that commit for a Fixes: tag.  It
touched the file in question but didn't add it in the first place; I
think 24e2d05d1b68 is the droid you're looking for.

jon