linux-kernel - Re: [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Jun 2022 10:44:15 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Vladimir Zapolskiy <vz@...ia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Roland Stigge <stigge@...com.de>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe

On Fri, Jun 03, 2022 at 06:12:30PM +0400, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  drivers/usb/host/ohci-nxp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c
> index 85878e8ad331..106a6bcefb08 100644
> --- a/drivers/usb/host/ohci-nxp.c
> +++ b/drivers/usb/host/ohci-nxp.c
> @@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev)
>  	}
>  
>  	isp1301_i2c_client = isp1301_get_client(isp1301_node);
> +	of_node_put(isp1301_node);
>  	if (!isp1301_i2c_client)
>  		return -EPROBE_DEFER;
>  
> -- 
> 2.25.1
>