linux-kernel - Re: [PATCH 1/1] iio: test: fix missing MODULE_LICENSE for IIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Jun 2022 16:13:14 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Liam Beguin <liambeguin@...il.com>
Cc:     rdunlap@...radead.org, peda@...ntia.se, masahiroy@...nel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/1] iio: test: fix missing MODULE_LICENSE for
 IIO_RESCALE=m

On Wed,  1 Jun 2022 10:21:38 -0400
Liam Beguin <liambeguin@...il.com> wrote:

> When IIO_RESCALE_KUNIT_TEST=y and IIO_RESCALE=m,
> drivers/iio/afe/iio-rescale.o is built twice causing the
> MODULE_LICENSE() to be lost, as shown by:
> 
> 	ERROR: modpost: missing MODULE_LICENSE() in drivers/iio/afe/iio-rescale.o
> 
> Rework the build configuration to have the dependency specified in the
> Kconfig.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 8e74a48d17d5 ("iio: test: add basic tests for the iio-rescale driver")
> Signed-off-by: Liam Beguin <liambeguin@...il.com>
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> Tested-by: Randy Dunlap <rdunlap@...radead.org>
> Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>
Applied to the fixes-togreg branch of iio.git.

Thanks all for chasing this down and coming up with a resolution.

Jonathan

> ---
>  drivers/iio/test/Kconfig  | 2 +-
>  drivers/iio/test/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/test/Kconfig b/drivers/iio/test/Kconfig
> index 56ca0ad7e77a..4c66c3f18c34 100644
> --- a/drivers/iio/test/Kconfig
> +++ b/drivers/iio/test/Kconfig
> @@ -6,7 +6,7 @@
>  # Keep in alphabetical order
>  config IIO_RESCALE_KUNIT_TEST
>  	bool "Test IIO rescale conversion functions"
> -	depends on KUNIT=y && !IIO_RESCALE
> +	depends on KUNIT=y && IIO_RESCALE=y
>  	default KUNIT_ALL_TESTS
>  	help
>  	  If you want to run tests on the iio-rescale code say Y here.
> diff --git a/drivers/iio/test/Makefile b/drivers/iio/test/Makefile
> index f15ae0a6394f..880360f8d02c 100644
> --- a/drivers/iio/test/Makefile
> +++ b/drivers/iio/test/Makefile
> @@ -4,6 +4,6 @@
>  #
>  
>  # Keep in alphabetical order
> -obj-$(CONFIG_IIO_RESCALE_KUNIT_TEST) += iio-test-rescale.o ../afe/iio-rescale.o
> +obj-$(CONFIG_IIO_RESCALE_KUNIT_TEST) += iio-test-rescale.o
>  obj-$(CONFIG_IIO_TEST_FORMAT) += iio-test-format.o
>  CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN)