linux-kernel - Re: [GIT PULL] More Kbuild updates for v5.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 4 Jun 2022 13:25:31 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [GIT PULL] More Kbuild updates for v5.19-rc1

On Fri, Jun 3, 2022 at 9:42 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
>  - Fix modpost to detect EXPORT_SYMBOL marked as __init or__exit
>    (This uncovered a couple of potential issues of exported symbols)

I pulled, and then unpulled again, since this introduces new warnings.

If you introduce new checks, you fix what it checks.

And if the warnings didn't get sorted out, then it wasn't ready to be merged.

There's a  good *reason* I require a clean build: non-clean builds
just mean that people will ignore new warnings because they think they
are the old ones that they have already seen.

So no, it is *NOT* ok to introduce new warnings and think "people will
fix these up because now there are warnings about it".

Quite the reverse. People not only *won't* fix things up, and it will
just hide new warnings from *other* things instead.

                   Linus