linux-kernel - Re: [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for i.MX8MP media blk ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Jun 2022 00:39:59 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     djakov@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        festevam@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, abel.vesa@....com,
        abailon@...libre.com, l.stach@...gutronix.de, marex@...x.de,
        paul.elder@...asonboard.com, Markus.Niebel@...tq-group.com,
        aford173@...il.com, kernel@...gutronix.de,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-imx@....com, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 1/8] dt-bindings: soc: imx: add interconnect property for
 i.MX8MP media blk ctrl

Hi Peng,

Thank you for the patch.

On Wed, Jun 01, 2022 at 05:45:30PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Add interconnect property for i.MX8MP mediamix blk ctrl
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  .../soc/imx/fsl,imx8mp-media-blk-ctrl.yaml         | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> index 21d3ee486295..706bef39b87e 100644
> --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml
> @@ -64,6 +64,20 @@ properties:
>        - const: isp
>        - const: phy
>  
> +  interconnects:
> +    maxItems: 8
> +
> +  interconnect-names:
> +    items:
> +      - const: lcdif-rd
> +      - const: lcdif-wr
> +      - const: isi0
> +      - const: isi1
> +      - const: isi2

If I understand correctly, these are for the 1x RD and 2x WR channels of
the ISI. Would it make sense to name thim accordingly, maybe isi-rd,
isi-wr0 and isi-wr1 ? I'm not sure about the order though.

> +      - const: isp0
> +      - const: isp1
> +      - const: dwe
> +
>  required:
>    - compatible
>    - reg

-- 
Regards,

Laurent Pinchart