linux-kernel - Re: linux-next: Fixes tag needs some work in the drm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220604103757.29d0b048@canb.auug.org.au>
Date:   Sat, 4 Jun 2022 10:37:57 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Rob Clark <robdclark@...il.com>
Cc:     Dave Airlie <airlied@...ux.ie>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Haowen Bai <baihaowen@...zu.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        DRI <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Clark <robdclark@...omium.org>
Subject: Re: linux-next: Fixes tag needs some work in the drm tree

Hi Rob,

On Fri, 3 Jun 2022 07:58:14 -0700 Rob Clark <robdclark@...il.com> wrote:
>
> will the truncated subject confuse the scripts that look for patches
> to backport to stable, ie. do we *really* have to rewrite history to
> fix this?

I don't know what scripts are being used and what they expect, but our
documentation says (Documentation/process/submitting-patches.rst):

  If your patch fixes a bug in a specific commit, e.g. you found an issue using
  ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
  the SHA-1 ID, and the one line summary.  Do not split the tag across multiple
  lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
  parsing scripts.

But, that being said, doing the rewrite is up to the maintainer.  You
could just look at this as a learning experience and do better in the
future.

BTW, my script reacted to the missing closing quotes and parentheses,
which is more like to confuse any scripts that the actual truncation.
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped