linux-kernel - Re: [PATCH v3 09/33] lib/printbuf: Unit specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0094a5d97b72d3d8e7864ec31941989f95f1ffdf.camel@perches.com>
Date:   Sat, 04 Jun 2022 18:06:37 -0700
From:   Joe Perches <joe@...ches.com>
To:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     pmladek@...e.com, rostedt@...dmis.org
Subject: Re: [PATCH v3 09/33] lib/printbuf: Unit specifiers

On Sat, 2022-06-04 at 15:30 -0400, Kent Overstreet wrote:
> This adds options to printbuf for specifying whether units should be
> printed raw (default) or with human readable units, and for controlling
> whether human-readable units should be base 2 (default), or base 10.
[]
> 
> This also adds new helpers that obey these options:
> 
>  - pr_human_readable_u64
>  - pr_human_readable_s64

Mismatched between commit message and code

> diff --git a/include/linux/printbuf.h b/include/linux/printbuf.h
[]
> @@ -53,10 +53,19 @@
[]
> +void prt_human_readable_u64(struct printbuf *, u64);
> +void prt_human_readable_s64(struct printbuf *, s64);

etc...

I think pb_ a better prefix