linux-kernel - Re: [PATCH 2/2] habanalabs: Fix kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 5 Jun 2022 13:06:41 +0300
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH 2/2] habanalabs: Fix kernel-doc

On Thu, Jun 2, 2022 at 6:58 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following W=1 kernel warnings:
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:425: warning: expecting
> prototype for hl_mmu_fini(). Prototype was for hl_mmu_v1_fini() instead.
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:449: warning: expecting
> prototype for hl_mmu_ctx_init(). Prototype was for hl_mmu_v1_ctx_init()
> instead.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu_v1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index e2d91a69acc2..ad4b49281cd7 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -412,7 +412,7 @@ static int hl_mmu_v1_init(struct hl_device *hdev)
>  }
>
>  /**
> - * hl_mmu_fini() - release the MMU module.
> + * hl_mmu_v1_fini() - release the MMU module.
>   * @hdev: habanalabs device structure.
>   *
>   * This function does the following:
> @@ -438,7 +438,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev)
>  }
>
>  /**
> - * hl_mmu_ctx_init() - initialize a context for using the MMU module.
> + * hl_mmu_v1_ctx_init() - initialize a context for using the MMU module.
>   * @ctx: pointer to the context structure to initialize.
>   *
>   * Initialize a mutex to protect the concurrent mapping flow, a hash to hold all
> --
> 2.20.1.7.g153144c
>

Both patches are
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>

Applied to -next.
Thanks,
Oded