linux-kernel - Re: [PATCH] Bluetooth: btbcm: Fix refcount leak in btbcm_get_board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ_9c44Vwg+1tbnnjgT_fr6A=GviKPVNanYm25yscsB5g@mail.gmail.com>
Date:   Sun, 5 Jun 2022 14:38:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btbcm: Fix refcount leak in btbcm_get_board_name

On Sun, Jun 5, 2022 at 8:56 AM Miaoqian Lin <linmq006@...il.com> wrote:

> of_find_node_by_path() returns a node pointer with refcount incremented,
> we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() in the error path to avoid refcount leak.
>
> Fixes: 63fac3343b99 ("Bluetooth: btbcm: Support per-board firmware variants")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Oops thanks!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij