linux-kernel - Re: [PATCH] dt-bindings: interrupt-controller: Convert rda,8810pl-intc to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b22f25-d5f1-efe2-f38f-a50c2dea0602@linaro.org>
Date:   Sun, 5 Jun 2022 16:50:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Stanislav Jakubek <stano.jakubek@...il.com>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-unisoc@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Convert
 rda,8810pl-intc to YAML

On 03/06/2022 14:12, Stanislav Jakubek wrote:
> On Sun, May 29, 2022 at 04:05:12PM +0200, Krzysztof Kozlowski wrote:
>> On 27/05/2022 14:56, Stanislav Jakubek wrote:
>>> Convert RDA Micro interrupt controller bindings to DT schema format.
>>>
>>> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>
>>> ---
>>>
>>> Didn't know what to do about the interrupt sources listed in the original txt file,
>>> so I've split them off into a separate file. Hope that's okay.
>>
>> Interrupt sources are not kept in header files.
> 
> Ok, should I move them somewhere else or is it fine to drop them?

Either drop them or, if they are meaningful, keep in description. I
doubt that they are meaningful, but who knows...

> 
>> Additionally are you
>> sure this is a property of the interrupt controller, not a property of
>> SoC itself? I would assume that one interrupt controller implementation
>> (e.g. GIC) can be used in different SoCs and the sources are every time
>> different because they depend on the actual wiring...
>>
> 
> I honestly have no idea, I just wanted to make some YAML conversions.
> Maybe Mani could answer this?


Best regards,
Krzysztof