linux-kernel - Re: [GIT pull] objtool/urgent for v5.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgjTMQgiKzBZTmb=uWGDEQxDdyF1+qxBkODYciuNsmwnw@mail.gmail.com>
Date:   Sun, 5 Jun 2022 10:13:59 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [GIT pull] objtool/urgent for v5.19-rc1

On Sun, Jun 5, 2022 at 2:30 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 06400504150b..6a663b27b286 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -218,7 +218,7 @@ objtool_args =                                                              \
>         $(if $(CONFIG_SLS), --sls)                                      \
>         $(if $(CONFIG_STACK_VALIDATION), --stackval)                    \
>         $(if $(CONFIG_HAVE_STATIC_CALL_INLINE), --static-call)          \
> -       --uaccess                                                       \
> +       $(if $(CONFIG_HAVE_UACCESS_VALIDATION), --uaccess)              \
>         $(if $(linked-object), --link)                                  \
>         $(if $(part-of-module), --module)                               \
>         $(if $(CONFIG_GCOV_KERNEL), --no-unreachable)

Since this clashed with the Kbuild cleanups I just merged, I looked at
it and threw up in my mouth a little.

Not a new problem, but can we do something like that attached, perhaps?

Untested, but looks trivially obvious. FamousLastWords(tm).

                  Linus

View attachment "patch.diff" of type "text/x-patch" (1823 bytes)