linux-kernel - Re: [PATCH] hwmon: (lm75) Replace kernel.h with the necessary inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220605174144.GA3144639@roeck-us.net>
Date:   Sun, 5 Jun 2022 10:41:44 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (lm75) Replace kernel.h with the necessary
 inclusions

On Fri, Jun 03, 2022 at 10:51:46PM +0200, Christophe JAILLET wrote:
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
> 
> Replace kernel.h inclusion with the list of what is really being used.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/lm75.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/lm75.h b/drivers/hwmon/lm75.h
> index a398171162a8..b803ada5e3c9 100644
> --- a/drivers/hwmon/lm75.h
> +++ b/drivers/hwmon/lm75.h
> @@ -11,7 +11,8 @@
>   * which contains this code, we don't worry about the wasted space.
>   */
>  
> -#include <linux/kernel.h>
> +#include <linux/minmax.h>
> +#include <linux/types.h>
>  
>  /* straight from the datasheet */
>  #define LM75_TEMP_MIN (-55000)