linux-kernel - Re: [PATCH v2] net: ethernet: bgmac: Fix refcount leak in bcma_mdio_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpztoGkCxT4KhXL5@lunn.ch>
Date:   Sun, 5 Jun 2022 19:53:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Rafał Miłecki <rafal@...ecki.pl>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Jon Mason <jon.mason@...adcom.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ethernet: bgmac: Fix refcount leak in
 bcma_mdio_mii_register

On Fri, Jun 03, 2022 at 05:32:38PM +0400, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew