linux-kernel - Re: [RFC v2 1/2] dt-bindings: usb: dwc3: Add support for multiport related properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62c0b6ac-240c-e581-7bc3-9357dc619d4c@quicinc.com>
Date:   Mon, 6 Jun 2022 00:01:19 +0530
From:   Harsh Agarwal <quic_harshq@...cinc.com>
To:     Rob Herring <robh@...nel.org>
CC:     <quic_pkondeti@...cinc.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        <quic_ppratap@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        <devicetree@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [RFC v2 1/2] dt-bindings: usb: dwc3: Add support for multiport
 related properties


On 6/1/2022 1:40 AM, Rob Herring wrote:
> On Fri, May 27, 2022 at 04:30:34PM +0530, Harsh Agarwal wrote:
>> On 5/26/2022 6:10 PM, Rob Herring wrote:
>>> On Thu, 26 May 2022 15:43:48 +0530, Harsh Agarwal wrote:
>>>> Added support for multiport, mport, num-ssphy and num-hsphy
>>>> properties. These properties are used to support devices having
>>>> a multiport controller.
>>>>
>>>> Signed-off-by: Harsh Agarwal <quic_harshq@...cinc.com>
>>>> ---
>>>>    .../devicetree/bindings/usb/snps,dwc3.yaml         | 55 ++++++++++++++++++++++
>>>>    1 file changed, 55 insertions(+)
>>>>
>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>
>>> yamllint warnings/errors:
>>> ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:366:8: [warning] wrong indentation: expected 6 but found 7 (indentation)
>>> ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:367:10: [warning] wrong indentation: expected 11 but found 9 (indentation)
>>> ./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:369:11: [warning] wrong indentation: expected 11 but found 10 (indentation)
>>>
>>> dtschema/dtc warnings/errors:
>>> Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:86.27-89.15: Warning (unit_address_vs_reg): /example-2/usb@...00000/multiport/mport@1: node has a unit name, but no reg or ranges property
>>> Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:91.27-93.15: Warning (unit_address_vs_reg): /example-2/usb@...00000/multiport/mport@2: node has a unit name, but no reg or ranges property
>>> Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:95.27-97.15: Warning (unit_address_vs_reg): /example-2/usb@...00000/multiport/mport@3: node has a unit name, but no reg or ranges property
>>> Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:99.27-101.15: Warning (unit_address_vs_reg): /example-2/usb@...00000/multiport/mport@4: node has a unit name, but no reg or ranges property
>>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.example.dtb: usb@...00000: multiport: 'mport' is a required property
>>> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>>>
>>> doc reference errors (make refcheckdocs):
>>>
>>> See https://patchwork.ozlabs.org/patch/
>>>
>>> This check can fail if there are any dependencies. The base for a patch
>>> series is generally the most recent rc1.
>>>
>>> If you already ran 'make dt_binding_check' and didn't see the above
>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>> date:
>>>
>>> pip3 install dtschema --upgrade
>>>
>>> Please check and re-submit.
>> Indentation error I have rectified in my RFC v2.
>> Regarding below warnings
>>
>> "Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:86.27-89.15: Warning (unit_address_vs_reg): /example-2/usb@...00000/multiport/mport@1: node has a unit name, but no reg or ranges property"
>> Here the mport expects no "reg" or ranges" property as of now. Only thing that is mandated is either the USB-PHY phandles using "usb-phy" or the Generic PHY declaration using "phy" and "phy-names"
>> Can you please suggest to mask these warnings or do I need to add something else ?
> A unit-address requires 'reg' or 'ranges' and vice-versa. So you need
> 'reg'.
>
> However, usb-hcd.yaml already defines what child nodes are for USB
> hosts. Whatever you do here needs to be compatible with that.
Thanks for the info.
"@" is not actually a requirement for mport.
We can name them as "mport1" instead of "mport@1".
Now I do not see this reg, ranges warnings in latest PS v2
>
> Rob