linux-kernel - Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220605212114.GA3528129-robh@kernel.org>
Date:   Sun, 5 Jun 2022 16:21:14 -0500
From:   Rob Herring <robh@...nel.org>
To:     Vabhav Sharma <vabhav.sharma@....com>
Cc:     horia.geanta@....com, gaurav.jain@....com, pankaj.gupta@....com,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        shawnguo@...nel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        silvano.dininno@....com, V.Sethi@....com
Subject: Re: [PATCH 1/3] dt-bindings: crypto: fsl: add entropy delay property

On Mon, May 30, 2022 at 11:39:22PM +0530, Vabhav Sharma wrote:
> Add entropy delay property which defines the length (in system clocks) of
> each Entropy sample taken for TRNG configuration.
> 
> Signed-off-by: Vabhav Sharma <vabhav.sharma@....com>
> Reviewed-by: Horia Geanta <horia.geanta@....com>
> Reviewed-by: Varun Sethi <v.sethi@....com>
> ---
>  Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> index 8f359f473ada..1477294eda38 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> +++ b/Documentation/devicetree/bindings/crypto/fsl-sec4.txt
> @@ -62,6 +62,12 @@ PROPERTIES
>        Definition: A standard property. Define the 'ERA' of the SEC
>            device.
>  
> +   - entropy-delay
> +      Usage: optional
> +      Value type: <u32>
> +      Definition: A property which specifies the length (in system clocks)
> +          of each Entropy sample taken.
> +

Seems like this could be common, but should be a time value (with unit 
suffix) rather than clocks. If not common, then needs a vendor prefix. 
Is this time to read a value or time between values produced? Not really 
clear from the description.

Rob