linux-kernel - Re: [PATCH v3 2/4] lib/test: Introduce cpumask KUnit test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd20ac398f85c6633a1f1e0d1df9249567c5a81d.camel@svanheule.net>
Date:   Sun, 05 Jun 2022 08:31:05 +0200
From:   Sander Vanheule <sander@...nheule.net>
To:     Peter Zijlstra <peterz@...radead.org>,
        Yury Norov <yury.norov@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Valentin Schneider <vschneid@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marco Elver <elver@...gle.com>
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v3 2/4] lib/test: Introduce cpumask KUnit test suite

On Sun, 2022-06-05 at 08:22 +0200, Sander Vanheule wrote:
> Add a basic suite of tests for cpumask, providing some tests for empty
> and completely filled cpumasks.
> 
> Signed-off-by: Sander Vanheule <sander@...nheule.net>
> ---
> +static void test_cpumask_iterators(struct kunit *test)
> +{
> +       EXPECT_FOR_EACH_CPU_EQ(test, &mask_empty);
> +       EXPECT_FOR_EACH_CPU_NOT_EQ(test, &mask_empty);
> +       EXPECT_FOR_EACH_CPU_WRAP_EQ(test, &mask_empty);
> +
> +       EXPECT_FOR_EACH_CPU_EQ(test, &mask_empty);
> +       EXPECT_FOR_EACH_CPU_NOT_EQ(test, &mask_empty);
> +       EXPECT_FOR_EACH_CPU_WRAP_EQ(test, &mask_empty);

This should be one block of &mask_empty, and one block of cpu_possible_mask. I'll fix this in v4
with other comments, or send an update tomorrow.

Best,
Sander