linux-kernel - Re: [PATCH] leds: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE-0n51JAxy0_znPeAevrE2MNLpe_rKmL0pcDOu9qApcRB1seQ@mail.gmail.com>
Date:   Mon, 6 Jun 2022 12:44:44 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Pavel Machek <pavel@....cz>,
        Satya Priya <quic_c_skakit@...cinc.com>,
        Wan Jiabing <wanjiabing@...o.com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: Add of_node_put() before return

Quoting Wan Jiabing (2022-06-01 00:52:03)
> Fix following coccicheck warning:
> drivers/leds/rgb/leds-qcom-lpg.c:1107:2-34: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1110.
> drivers/leds/rgb/leds-qcom-lpg.c:1286:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1289.
>
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter.
>
> Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG")
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>