[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <75b293bd-ec8d-8c90-ffe5-afa49d6a218d@wanadoo.fr>
Date: Mon, 6 Jun 2022 22:42:07 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Wong Vee Khee <vee.khee.wong@...ux.intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] stmmac: intel: Fix an error handling path in
intel_eth_pci_probe()
Le 06/06/2022 à 08:26, Wong Vee Khee a écrit :
> On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote:
>> When the managed API is used, there is no need to explicitly call
>> pci_free_irq_vectors().
>>
>> This looks to be a left-over from the commit in the Fixes tag. Only the
>> .remove() function had been updated.
>>
>> So remove this unused function call and update goto label accordingly.
>>
>> Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>
> LGTM
>
> Reviewed-by: Wong Vee Khee <vee.khee.wong@...ux.intel.com>
>
>
Hi,
I've looked at it again.
I still think that the patch is good, but pcim_release() has changed in
5.18 since commit 3f35d2cf9fbc ("PCI/MSI: Decouple MSI[-X] disable from
pcim_release()")
I guess that all the mechanic is in place so that everything is
registered when needed, but I've not been able to figure it out in the
case of dwmac-intel.c.
So, double check :).
CJ
Powered by blists - more mailing lists