[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2022 16:32:43 -0500
From: Rob Herring <robh@...nel.org>
To: Miaoqian Lin <linmq006@...il.com>
Cc: Daire McNamara <daire.mcnamara@...rochip.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
PCI <linux-pci@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains
On Sun, Jun 5, 2022 at 12:51 AM Miaoqian Lin <linmq006@...il.com> wrote:
>
> of_get_next_child() returns a node pointer with refcount incremented,
> we should use of_node_put() on it when not need anymore.
> This function only call of_node_put() in normal path,
> missing it in some error paths.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
> drivers/pci/controller/pcie-microchip-host.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists