linux-kernel - Re: [PATCH v2 2/3] leds: Add driver for the TLC5925 LED controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Jun 2022 17:20:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jean-Jacques Hiblot <jjhiblot@...phandler.com>, pavel@....cz,
        krzk+dt@...nel.org
Cc:     kbuild-all@...ts.01.org, robh+dt@...nel.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jean-Jacques Hiblot <jjhiblot@...phandler.com>
Subject: Re: [PATCH v2 2/3] leds: Add driver for the TLC5925 LED controller

Hi Jean-Jacques,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pavel-leds/for-next]
[also build test WARNING on v5.18 next-20220603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Jean-Jacques-Hiblot/Add-support-for-the-TLC5925/20220605-235250
base:   git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220606/202206061749.4bLA99z3-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/e8ae916efd705311a0bdeb2a8f9a1649174867be
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jean-Jacques-Hiblot/Add-support-for-the-TLC5925/20220605-235250
        git checkout e8ae916efd705311a0bdeb2a8f9a1649174867be
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/leds/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/leds/leds-tlc5925.c:144:35: warning: 'tlc5925_id' defined but not used [-Wunused-const-variable=]
     144 | static const struct spi_device_id tlc5925_id[] = {
         |                                   ^~~~~~~~~~


vim +/tlc5925_id +144 drivers/leds/leds-tlc5925.c

   143	
 > 144	static const struct spi_device_id tlc5925_id[] = {
   145		{"tlc5925", 0},
   146		{}
   147	};
   148	MODULE_DEVICE_TABLE(spi, tlc5925_id);
   149	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp