lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jun 2022 15:40:20 +0200 From: Javier Martinez Canillas <javierm@...hat.com> To: José Expósito <jose.exposito89@...il.com> Cc: davidgow@...gle.com, dlatypov@...gle.com, tzimmermann@...e.de, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() Hello José, On 6/6/22 11:55, José Expósito wrote: > Test the conversion from XRGB8888 to RGB332. > > What is tested? > > - Different values for the X in XRGB8888 to make sure it is ignored > - Different clip values: Single pixel and full and partial buffer > - Well known colors: White, black, red, green, blue, magenta, yellow > and cyan > - Other colors: Randomly picked > - Destination pitch > > How to run the tests? > > $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \ > --kconfig_add CONFIG_VIRTIO_UML=y \ > --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > > Suggested-by: Javier Martinez Canillas <javierm@...hat.com> > Signed-off-by: José Expósito <jose.exposito89@...il.com> > > --- Thanks for addressing the issues pointed out. Patch looks good to me now. Reviewed-by: Javier Martinez Canillas <javierm@...hat.com> By the way, I think you should request an account [0], so that you can push patches to drm-misc directly. Specially since AFAIU the plan is to add more KUnit tests in future patch series. [0]: https://www.freedesktop.org/wiki/AccountRequests/ -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Powered by blists - more mailing lists