[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2022 15:57:45 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Maxime Ripard <maxime@...no.tech>
Cc: José Expósito <jose.exposito89@...il.com>,
davidgow@...gle.com, dlatypov@...gle.com, tzimmermann@...e.de,
maarten.lankhorst@...ux.intel.com, airlied@...ux.ie,
daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drm/format-helper: Add KUnit tests for
drm_fb_xrgb8888_to_rgb332()
Hello Maxime,
On 6/6/22 15:52, Maxime Ripard wrote:
> hi,
>
> On Mon, Jun 06, 2022 at 03:49:57PM +0200, Javier Martinez Canillas wrote:
>> Hello Maxime,
>>
>> On 6/6/22 15:42, Maxime Ripard wrote:
>>> Hi,
>>>
>>> On Mon, Jun 06, 2022 at 11:55:16AM +0200, José Expósito wrote:
>>>> Test the conversion from XRGB8888 to RGB332.
>>>>
>>>> What is tested?
>>>>
>>>> - Different values for the X in XRGB8888 to make sure it is ignored
>>>> - Different clip values: Single pixel and full and partial buffer
>>>> - Well known colors: White, black, red, green, blue, magenta, yellow
>>>> and cyan
>>>> - Other colors: Randomly picked
>>>> - Destination pitch
>>>>
>>>> How to run the tests?
>>>>
>>>> $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm \
>>>> --kconfig_add CONFIG_VIRTIO_UML=y \
>>>> --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
>>>
>>> It's not clear to me why you would need VIRTIO here? The Kunit config
>>> file should be enough to run the tests properly
>>>
>>
>> It's needed or otherwise KUnit will complain with:
>>
>> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig
>> [15:47:31] Configuring KUnit Kernel ...
>> Regenerating .config ...
>> Populating config with:
>> $ make ARCH=um O=.kunit olddefconfig
>> ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
>> This is probably due to unsatisfied dependencies.
>> Missing: CONFIG_DRM=y, CONFIG_DRM_KUNIT_TEST=y
>> Note: many Kconfig options aren't available on UML. You can try running on a different architecture with something like "--arch=x86_64".
>>
>> The following works correctly but it won't use User Mode Linux:
>>
>> ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig --arch=x86_64
>
> But then, can't we add them to .kunitconfig?
>
That's what I asked in the previous RFC too. Daniel mentioned that it shouldn't
go there because is platform specific (AFAIU, one might want to test it on x86,
aarch64, etc) but then I asked why we couldn't have a arch/um/.kunitconfig.
The answer was that's not that simple and some agreement on how to do it is needed:
https://lists.freedesktop.org/archives/dri-devel/2022-June/357617.html
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
Powered by blists - more mailing lists