[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2022 17:52:29 +0100
From: Mark Brown <broonie@...nel.org>
To: Lukasz Majewski <lukma@...x.de>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data
On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote:
> > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote:
> > > The lack of platform data in the contemporary Linux
> > > shall not be the reason to display warnings to the
> > > kernel logs.
> > Given that the device requires configuration and doesn't appear to
> > have any other firmware interface support that's rather a strong
> > statement...
> My point is that - similar codec - wm8974 don't display such warnings.
> (this code was not updated/refactored for a quite long time).
Perhaps those drivers are buggy, or those devices lack this specific
configuration that's being adjusted? The changelog should at least
address why the driver was warning about configuration being required
but it's safe to ignore that.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists