linux-kernel - Re: [PATCH v2] KVM: x86/mmu: Check every prev_roots in __kvm_mmu_free_obsolete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1abaea0d-7e21-b596-eb5d-75217133a504@intel.com>
Date:   Tue, 7 Jun 2022 23:00:51 +0800
From:   "Huang, Shaoqin" <shaoqin.huang@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>
CC:     <pbonzini@...hat.com>, Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ben Gardon <bgardon@...gle.com>,
        <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] KVM: x86/mmu: Check every prev_roots in
 __kvm_mmu_free_obsolete_roots()

Thanks Sean!

On 6/7/2022 12:56 AM, Sean Christopherson wrote:
> On Mon, Jun 06, 2022, shaoqin.huang@...el.com wrote:
>> From: Shaoqin Huang <shaoqin.huang@...el.com>
>>
>> When freeing obsolete previous roots, check prev_roots as intended, not
>> the current root.
>>
>> Signed-off-by: Shaoqin Huang <shaoqin.huang@...el.com>
>> Fixes: 527d5cd7eece ("KVM: x86/mmu: Zap only obsolete roots if a root shadow page is zapped")
> 
> Because KVM patches aren't guaranteed to be backported without it (though it's
> "only" v5.18 that's affected), this needs:
> 
>    Cc: stable@...r.kernel.org
> 
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>