linux-kernel - Re: [RESEND v4 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220607151119.GA3254370-robh@kernel.org>
Date:   Tue, 7 Jun 2022 09:11:19 -0600
From:   Rob Herring <robh@...nel.org>
To:     Rex-BC Chen <rex-bc.chen@...iatek.com>
Cc:     Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "pavel@....cz" <pavel@....cz>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        CK Hu (胡俊光) <ck.hu@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Subject: Re: [RESEND v4 1/3] dt-bindings: mediatek: add vdosys1 RDMA
 definition for mt8195

On Mon, Jun 06, 2022 at 09:30:42PM +0800, Rex-BC Chen wrote:
> On Mon, 2022-06-06 at 20:53 +0800, Rob Herring wrote:
> > On Mon, 06 Jun 2022 13:11:29 +0800, Bo-Chen Chen wrote:
> > > From: "Nancy.Lin" <nancy.lin@...iatek.com>
> > > 
> > > Add vdosys1 RDMA definition.
> > > 
> > > Signed-off-by: Nancy.Lin <nancy.lin@...iatek.com>
> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@...labora.com>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > Tested-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@...labora.com>
> > > ---
> > >  .../display/mediatek/mediatek,mdp-rdma.yaml   | 88
> > > +++++++++++++++++++
> > >  1 file changed, 88 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > > rdma.yaml
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-
> > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md
> > p-rdma.yaml: properties:compatible: [{'const': 'mediatek,mt8195-vdo1-
> > rdma'}] is not of type 'object', 'boolean'
> > 	from schema $id: 
> > https://urldefense.com/v3/__http://json-schema.org/draft-07/schema*__;Iw!!CTRNKA9wMg0ARbw!3hhZrSKSWnCN5Bha9laiHlB5JCx9_p-ksaYDZmoCLQRi1tI4KJCcTJQva2vds3j3bwKF$
> >  
> > /builds/robherring/linux-dt-
> > review/Documentation/devicetree/bindings/display/mediatek/mediatek,md
> > p-rdma.yaml: ignoring, error in schema: properties: compatible
> > Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-
> > rdma.example.dtb:0:0: /example-0/soc/rdma@...04000: failed to match
> > any schema with compatible: ['mediatek,mt8195-vdo1-rdma']
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/patch/
> > 
> > This check can fail if there are any dependencies. The base for a
> > patch
> > series is generally the most recent rc1.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up
> > to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit.
> > 
> 
> Hello Rob,
> 
> We found that if we write this, and the error will disapear:
>  properties:
>    compatible:
> -    - const: mediatek,mt8195-vdo1-rdma
> +    items:
> +      - const: mediatek,mt8195-vdo1-rdma
> 
> But from Krzysztof's review[1], he adviced us to drop items.
> 
> Is there any suggsetion for this error or do we have any
> misunderstanding?

The '-' is important.

compatible:
  const: mediatek,mt8195-vdo1-rdma