linux-kernel - Re: [PATCH V2 1/1] comedi: ni_usb6501: fix transfer-buffer overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Jun 2022 17:39:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Xiaohui Zhang <xiaohuizhang@....edu.cn>
Cc:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/1] comedi: ni_usb6501: fix transfer-buffer overflows

On Tue, Jun 07, 2022 at 09:47:20PM +0800, Xiaohui Zhang wrote:
> Similar to the handling of vmk80xx_alloc_usb_buffers in commit
> a23461c47482("comedi: vmk80xx: fix transfer-buffer overflows"),
> we thought a patch might be needed here as well.
> 
> The driver uses endpoint-sized USB transfer buffers but up until
> recently had no sanity checks on the sizes.
> 
> ---
> 
> Fix the typo in the last bit of the old patch which use the wrong
> endpoint to determine the size for usb_tx_buf.
> 
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@....edu.cn>
> ---

Please read the documentation links I sent you that say how to properly
document this.

Please do so and then you can submit a v3.

thanks,

greg k-h