linux-kernel - Re: [PATCH] fs/ntfs3: remove redundant assignment to variable frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d81ad89-57c4-88a9-8730-14c0fd9bb075@paragon-software.com>
Date:   Tue, 7 Jun 2022 19:22:31 +0300
From:   Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
To:     Colin Ian King <colin.i.king@...il.com>, <ntfs3@...ts.linux.dev>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <llvm@...ts.linux.dev>
Subject: Re: [PATCH] fs/ntfs3: remove redundant assignment to variable frame



On 12/30/21 18:59, Colin Ian King wrote:
> Variable frame is assigned a value that is never read. The
> assignment is redundant and can be removed. Cleans up the
> clang-scan build warning:
> 
> fs/ntfs3/file.c:995:3: warning: Value stored to 'frame' is
> never read [deadcode.DeadStores]
>                  frame = pos >> frame_bits;
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   fs/ntfs3/file.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
> index 3bae76930e68..27c32692513c 100644
> --- a/fs/ntfs3/file.c
> +++ b/fs/ntfs3/file.c
> @@ -992,7 +992,6 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
>   		if (bytes > count)
>   			bytes = count;
>   
> -		frame = pos >> frame_bits;
>   		frame_vbo = pos & ~(frame_size - 1);
>   		index = frame_vbo >> PAGE_SHIFT;
>   

Applied, thanks!