[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220607162942.GA3384053-robh@kernel.org>
Date: Tue, 7 Jun 2022 10:29:42 -0600
From: Rob Herring <robh@...nel.org>
To: Abel Vesa <abel.vesa@....com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Shawn Guo <shawnguo@...nel.org>,
Dong Aisheng <aisheng.dong@....com>,
NXP Linux Team <linux-imx@....com>,
devicetree@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/10] dt-bindings: arm: freescale: Add fsl,scu-clk yaml
file
On Tue, Jun 07, 2022 at 01:59:43PM +0300, Abel Vesa wrote:
> This documents separately the clock child node of the SCU main node.
>
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> ---
> .../bindings/arm/freescale/fsl,scu-clk.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,scu-clk.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-clk.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-clk.yaml
> new file mode 100644
> index 000000000000..f6b97439ce38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-clk.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/freescale/fsl,scu-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Clock bindings based on SCU Message Protocol
> +
> +maintainers:
> + - Shawn Guo <shawnguo@...nel.org>
> +
> +description: i.MX SCU Client Device Node
> + Client nodes are maintained as children of the relevant IMX-SCU device node.
> + This binding uses the common clock binding.
> + (Documentation/devicetree/bindings/clock/clock-bindings.txt)
> + The clock consumer should specify the desired clock by having the clock
> + ID in its "clocks" phandle cell.
> + See the full list of clock IDs from
> + include/dt-bindings/clock/imx8qxp-clock.h
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx8dxl-clk
> + - fsl,imx8qm-clk
> + - fsl,imx8qxp-clk
> + - const: fsl,scu-clk
> + - items:
> + - const: fsl,imx8qxp-clk
Why do you need to support with and without a fallback?
> + '#clock-cells':
> + const: 2
> + clocks:
> + minItems: 1
> + maxItems: 3
Need to define what are the clock entries.
> + clock-names:
> + minItems: 1
> + maxItems: 3
Need to define the names.
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - '#clock-cells'
> --
> 2.34.3
>
>
Powered by blists - more mailing lists