linux-kernel - Re: [git pull] drm for 5.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877d5s2zak.fsf@igel.home>
Date:   Tue, 07 Jun 2022 18:50:27 +0200
From:   Andreas Schwab <schwab@...ux-m68k.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Dave Airlie <airlied@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [git pull] drm for 5.19-rc1

On Jun 07 2022, Geert Uytterhoeven wrote:

> On Wed, May 25, 2022 at 4:49 PM Dave Airlie <airlied@...il.com> wrote:
>>       drm/amdgpu: add nbio v7_7_0 ip headers
>
> These header files are heavy users of large constants lacking the "U"
> suffix e.g.:
>
>     #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xFFFF0000L
>
> Assigning this to unsigned long on 32-bit will trigger a signed integer
> overflow, which is technically UB, and causes "error: initializer
> element is not constant" warnings with gcc-5 and -std-gnu11, cfr. [1]

That shouldn't happen here, as hexadecimal constants will be of unsigned
type if they don't fit in the corresponding signed type.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."