[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220607175259.478835-29-sashal@kernel.org>
Date: Tue, 7 Jun 2022 13:52:26 -0400
From: Sasha Levin <sashal@...nel.org>
To: linux-kernel@...r.kernel.org, stable@...r.kernel.org
Cc: Zheng Bin <zhengbin13@...wei.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sasha Levin <sashal@...nel.org>, w.d.hubbs@...il.com,
chris@...-brannons.com, kirk@...sers.ca,
samuel.thibault@...-lyon.org, salah.triki@...il.com,
trix@...hat.com, speakup@...ux-speakup.org
Subject: [PATCH AUTOSEL 5.17 29/60] accessiblity: speakup: Add missing misc_deregister in softsynth_probe
From: Zheng Bin <zhengbin13@...wei.com>
[ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ]
softsynth_probe misses a call misc_deregister() in an error path, this
patch fixes that.
Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
Link: https://lore.kernel.org/r/20220511032937.2736738-1-zhengbin13@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---
drivers/accessibility/speakup/speakup_soft.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
index 19824e7006fe..786dc5d080f3 100644
--- a/drivers/accessibility/speakup/speakup_soft.c
+++ b/drivers/accessibility/speakup/speakup_soft.c
@@ -397,6 +397,7 @@ static int softsynth_probe(struct spk_synth *synth)
synthu_device.name = "softsynthu";
synthu_device.fops = &softsynthu_fops;
if (misc_register(&synthu_device)) {
+ misc_deregister(&synth_device);
pr_warn("Couldn't initialize miscdevice /dev/softsynthu.\n");
return -ENODEV;
}
--
2.35.1
Powered by blists - more mailing lists