linux-kernel - Re: [PATCH] sched/deadline: Use proc_douintvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32bfd9554e9afcb0f8eaec247e253b3d@linux.dev>
Date:   Tue, 07 Jun 2022 01:26:43 +0000
From:   "Yajun Deng" <yajun.deng@...ux.dev>
To:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/deadline: Use proc_douintvec_minmax() limit
 minimum value

Ping.



May 13, 2022 10:41 AM, "Yajun Deng" <yajun.deng@...ux.dev> wrote:

> proc_dointvec() is not applicable for unsigned integer, use
> proc_douintvec_minmax() limit minimum value.
> 
> Signed-off-by: Yajun Deng <yajun.deng@...ux.dev>
> ---
> kernel/sched/deadline.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 85cd62e0dddd..4d2a780c6f73 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -30,14 +30,16 @@ static struct ctl_table sched_dl_sysctls[] = {
> .data = &sysctl_sched_dl_period_max,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_douintvec_minmax,
> + .extra1 = (void *)&sysctl_sched_dl_period_min,
> },
> {
> .procname = "sched_deadline_period_min_us",
> .data = &sysctl_sched_dl_period_min,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_douintvec_minmax,
> + .extra2 = (void *)&sysctl_sched_dl_period_max,
> },
> {}
> };
> -- 
> 2.25.1