linux-kernel - RE: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB4865CA9098EA7E1C052823D792A59@CO1PR11MB4865.namprd11.prod.outlook.com>
Date:   Tue, 7 Jun 2022 07:54:54 +0000
From:   <Kavyasree.Kotagiri@...rochip.com>
To:     <krzysztof.kozlowski@...aro.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Claudiu.Beznea@...rochip.com>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible
 string for lan966x

> >>> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> in
> >>> flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> >>> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage
> >> depends on
> >>> functions being configured.
> >>>
> >>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> >>> ---
> >>>  .../bindings/mfd/atmel,flexcom.yaml           | 21 ++++++++++++++++++-
> >>>  1 file changed, 20 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> index 221bd840b49e..6050482ad8ef 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> @@ -16,7 +16,9 @@ description:
> >>>
> >>>  properties:
> >>>    compatible:
> >>> -    const: atmel,sama5d2-flexcom
> >>> +    enum:
> >>> +      - atmel,sama5d2-flexcom
> >>> +      - microchip,lan966x-flexcom
> >>
> >> Your new v1 is here worse than old v2, where this was just simple
> >> extension of existing enum. Why did you change it?
> >>
> > I introduced new compatible string for lan966x and also I have new DT
> properties
> > "microchip,flx-shrd-pins" and "microchip,flx-cs-names".
> 
> v1 also had the new compatible, hadn't it? The difference is in the enum
> - before you did not modify this line. Less code in the diff...
> 
Yes, previous patch series also had new compatible which introduced new mux DT properties in atmel-flexcom.yaml and mux driver.
As part of review comments from Peter Rosin on driver part, Mux implementation is dropped. Please ignore previous patch series. Now, flexcom chip-select support is done in atme-flexcom.c driver. So, I started new patch series now which introduced new DT properties "microchip,flx-shrd-pins" and "microchip,flx-cs-names" and driver changes only in atmel-flexcom.c driver.
> 
> Best regards,
> Krzysztof