linux-kernel - Re: [PATCH] sched/deadline: Use proc_douintvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9150a4ffa0ff94ab4697d615c60ed9b4@linux.dev>
Date:   Tue, 07 Jun 2022 08:35:56 +0000
From:   "Yajun Deng" <yajun.deng@...ux.dev>
To:     "Daniel Bristot de Oliveira" <bristot@...hat.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        dietmar.eggemann@....com, bsegall@...gle.com, vschneid@...hat.com,
        rostedt@...dmis.org, mgorman@...e.de, vincent.guittot@...aro.org
Subject: Re: [PATCH] sched/deadline: Use proc_douintvec_minmax() limit
 minimum value

June 7, 2022 3:55 PM, "Daniel Bristot de Oliveira" <bristot@...hat.com> wrote:

> Hi Yajun
> 
> On 5/13/22 04:41, Yajun Deng wrote:
> 
>> proc_dointvec() is not applicable for unsigned integer, use
>> proc_douintvec_minmax() limit minimum value.
> 
> I understand your patch, but your log message is somehow incomplete.
> 
> Could you expand on that, showing the problem using an example, and then how you
> see it fixed?
> 

This patch isn't a fix. It's just an optimization for match data and proc_handler in struct ctl_table.

> Also, could you please add the Fixes: tag so this patch can land on stable trees?
> 

This statement 'if (period < min || period > max)' in __checkparam_dl() will work fine even if there hasn't this patch.
So this patch may not need land on stable trees.

> -- Daniel