lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Jun 2022 20:46:33 +0200 From: Stephen Kitt <steve@....org> To: "Lee, Chun-Yi" <jlee@...e.com>, Hans de Goede <hdegoede@...hat.com>, Mark Gross <markgross@...nel.org>, Cezary Jackiewicz <cezary.jackiewicz@...il.com>, Henrique de Moraes Holschuh <hmh@....eng.br> Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, Stephen Kitt <steve@....org> Subject: [PATCH 2/4] platform/x86: apple-gmux: Use backlight helper Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt <steve@....org> Cc: Hans de Goede <hdegoede@...hat.com> Cc: Mark Gross <markgross@...nel.org> Cc: platform-driver-x86@...r.kernel.org --- drivers/platform/x86/apple-gmux.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c index 57553f9b4d1d..ffe98a18440b 100644 --- a/drivers/platform/x86/apple-gmux.c +++ b/drivers/platform/x86/apple-gmux.c @@ -291,10 +291,7 @@ static int gmux_get_brightness(struct backlight_device *bd) static int gmux_update_status(struct backlight_device *bd) { struct apple_gmux_data *gmux_data = bl_get_data(bd); - u32 brightness = bd->props.brightness; - - if (bd->props.state & BL_CORE_SUSPENDED) - return 0; + u32 brightness = backlight_get_brightness(bd); gmux_write32(gmux_data, GMUX_PORT_BRIGHTNESS, brightness); -- 2.30.2
Powered by blists - more mailing lists