linux-kernel - Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeTHUe=VCs-mq27ffk6uFXZ-vkPvb=r7S1S8-_oi1FtJw@mail.gmail.com>
Date:   Tue, 7 Jun 2022 12:01:44 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] tty/vt: Makefile, add --unicode for loadkeys invocation

On Tue, Jun 7, 2022 at 11:58 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Tue, Jun 7, 2022 at 7:42 AM Jiri Slaby <jirislaby@...nel.org> wrote:
> > On 06. 06. 22, 16:35, Andy Shevchenko wrote:
> > > On Thu, Jun 2, 2022 at 12:30 PM Jiri Slaby <jslaby@...e.cz> wrote:
> > >>
> > >> For a long time, we generate unicode tables using loadkeys. So fix
> > >> Makefile to use that flag too.
> > >
> > > generated
> >
> > We still do, but I didn't even know there is even a rule for that ;).
>
> I understand, but here is English stylistics like this. You need to
> use past ind. or present perfect ("for a long time" dictates that).

Okay, now even more explanation, present perfect should be used here.

we have generated


-- 
With Best Regards,
Andy Shevchenko