linux-kernel - Re: [PATCH] perf unwind: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220607002658.zkbs4c37ihmivcmn@google.com>
Date:   Mon, 6 Jun 2022 17:26:58 -0700
From:   Fangrui Song <maskray@...gle.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sedat Dilek <sedat.dilek@...il.com>, llvm@...ts.linux.dev,
        Sebastian Ullrich <sebasti@...lri.ch>
Subject: Re: [PATCH] perf unwind: Fix uninitialized variable

On 2022-06-06, Ian Rogers wrote:
>ret may be uninitialized on error goto paths.
>
>Reported-by: Sedat Dilek <sedat.dilek@...il.com>
>Fixes: dc2cf4ca866f ("perf unwind: Fix segbase for ld.lld linked objects")
>Signed-off-by: Ian Rogers <irogers@...gle.com>

Thanks. Sorry for my mistake...

Reviewed-by: Fangrui Song <maskray@...gle.com>

>---
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
>index 37622699c91a..6e5b8cce47bf 100644
>--- a/tools/perf/util/unwind-libunwind-local.c
>+++ b/tools/perf/util/unwind-libunwind-local.c
>@@ -174,7 +174,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address
> 	Elf *elf;
> 	GElf_Ehdr ehdr;
> 	GElf_Shdr shdr;
>-	int ret;
>+	int ret = -1;
>
> 	elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
> 	if (elf == NULL)
>-- 
>2.36.1.255.ge46751e96f-goog
>