linux-kernel - Re: [PATCH] au1000_eth: stop using virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOLZvyFvSJ_+SJCY6T5zBTetf-oezm+A9w6gR+cnLOC4T+8HwA@mail.gmail.com>
Date:   Tue, 7 Jun 2022 12:35:15 +0200
From:   Manuel Lauss <manuel.lauss@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] au1000_eth: stop using virt_to_bus()

On Tue, Jun 7, 2022 at 11:02 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The conversion to the dma-mapping API in linux-2.6.11 was incomplete
> and left a virt_to_bus() call around. There have been a number of
> fixes for DMA mapping API abuse in this driver, but this one always
> slipped through.
>
> Change it to just use the existing dma_addr_t pointer, and make it
> use the correct types throughout the driver to make it easier to
> understand the virtual vs dma address spaces.
>
> Cc: Manuel Lauss <manuel.lauss@...il.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

lightly tested on a DB1500 board, without issues.

Tested-by: Manuel Lauss <manuel.lauss@...il.com>

Thanks!