linux-kernel - Re: [PATCH 00/10] Convert to filemap_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220607113716.aec2o7onzu3re2o4@wittgenstein>
Date:   Tue, 7 Jun 2022 13:37:16 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-mm@...ck.org, linux-nilfs@...r.kernel.org
Subject: Re: [PATCH 00/10] Convert to filemap_get_folios()

On Sun, Jun 05, 2022 at 08:38:44PM +0100, Matthew Wilcox wrote:
> This patch series removes find_get_pages_range(), pagevec_lookup()
> and pagevec_lookup_range(), converting all callers to use the new
> filemap_get_folios().  I've only run xfstests over ext4 ... some other
> testing might be appropriate.
> 
> Matthew Wilcox (Oracle) (10):
>   filemap: Add filemap_get_folios()
>   buffer: Convert clean_bdev_aliases() to use filemap_get_folios()
>   ext4: Convert mpage_release_unused_pages() to use filemap_get_folios()
>   ext4: Convert mpage_map_and_submit_buffers() to use
>     filemap_get_folios()
>   f2fs: Convert f2fs_invalidate_compress_pages() to use
>     filemap_get_folios()
>   hugetlbfs: Convert remove_inode_hugepages() to use
>     filemap_get_folios()
>   nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()
>   vmscan: Add check_move_unevictable_folios()
>   shmem: Convert shmem_unlock_mapping() to use filemap_get_folios()
>   filemap: Remove find_get_pages_range() and associated functions
> 
>  fs/buffer.c             | 26 +++++++--------
>  fs/ext4/inode.c         | 40 ++++++++++++-----------
>  fs/f2fs/compress.c      | 35 +++++++++-----------
>  fs/hugetlbfs/inode.c    | 44 ++++++++-----------------
>  fs/nilfs2/page.c        | 60 +++++++++++++++++-----------------
>  include/linux/pagemap.h |  5 ++-
>  include/linux/pagevec.h | 10 ------
>  include/linux/swap.h    |  3 +-
>  mm/filemap.c            | 72 +++++++++++++++++------------------------
>  mm/shmem.c              | 13 ++++----
>  mm/swap.c               | 29 -----------------
>  mm/vmscan.c             | 55 ++++++++++++++++++-------------
>  12 files changed, 166 insertions(+), 226 deletions(-)

The conversion seems fairly straightforward, so looks good to me.
Acked-by: Christian Brauner (Microsoft) <brauner@...nel.org>