linux-kernel - Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOX2RU5zUMEVZeScSPV6MvzvxwghECJy1DHDTfW5CFDeyPuE+A@mail.gmail.com>
Date:   Tue, 7 Jun 2022 14:42:38 +0200
From:   Robert Marko <robimarko@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     sravanhome@...il.com, lgirdwood@...il.com, broonie@...nel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes

On Sat, 4 Jun 2022 at 17:41, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 04/06/2022 à 16:56, Robert Marko a écrit :
> > Sort the header include list alphabetically.
> >
> > Signed-off-by: Robert Marko <robimarko@...il.com>
> > ---
> >   drivers/regulator/mp5416.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c
> > index 39cebec0edb6..d8245080df03 100644
> > --- a/drivers/regulator/mp5416.c
> > +++ b/drivers/regulator/mp5416.c
> > @@ -6,14 +6,14 @@
> >   //
> >   // Author: Saravanan Sekar <sravanhome@...il.com>
> >
> > +#include <linux/err.h>
> > +#include <linux/i2c.h>
> > +#include <linux/init.h>
> >   #include <linux/kernel.h>
>
> Nitpick: it seems that kernel.h is not needed here. (at least it compile
> without it).

Hi,

It also seems to work fine without it, will send a patch to remove it.

Regards,
Robert
>
> CJ
>
> >   #include <linux/module.h>
> > -#include <linux/init.h>
> > -#include <linux/err.h>
> >   #include <linux/platform_device.h>
> >   #include <linux/regmap.h>
> >   #include <linux/regulator/driver.h>
> > -#include <linux/i2c.h>
> >
> >   #define MP5416_REG_CTL0                     0x00
> >   #define MP5416_REG_CTL1                     0x01
>