linux-kernel - Re: [PATCH 07/36] tty/vt: consolemap: make parameters of inverse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83d6e90-c9f4-883c-285f-9ba7f85e937b@linux.intel.com>
Date:   Tue, 7 Jun 2022 16:32:33 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jslaby@...e.cz>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/36] tty/vt: consolemap: make parameters of
 inverse_translate() saner

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> - int use_unicode -> bool: it's used as bool at some places already, so
>   make it explicit.
> - int glyph -> u16: every caller passes a u16 in. So make it explicit
>   too. And remove a negative check from inverse_translate() as it never
>   could be negative.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>


-- 
 i.